Add new generic add method #530
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he data serialization
hugtalbot
added
pr: experimental
pr: status wip
and removed
pr: status to review
labels
| self.assertEqual(root.FirstNode.objects()[0].type.value, "RequiredPlugin") | ||
| self.assertEqual(root.FirstNode.objects()[0].name.value, "FirstNode") | ||
|
|
||
| pass |
There was a problem hiding this comment.
Suggested change
| pass |
| self.assertEqual(root.objects()[0].type.value, "RequiredPlugin") | ||
| self.assertEqual(root.objects()[0].name.value, "FirstNode") | ||
|
|
||
| pass |
There was a problem hiding this comment.
Suggested change
| pass |
| root.add(MyNode) | ||
| self.assertEqual(root.children()[0].name.value, "MyNode") | ||
|
|
||
| pass |
There was a problem hiding this comment.
Suggested change
| pass |
| } | ||
| } | ||
|
|
||
| py::object add( Node* self, const std::string& type, const py::kwargs& kwargs) |
There was a problem hiding this comment.
I suggest to add a second signature so we can pass real type instead of string.
py::object add( Node* self, py::type type, const py::kwargs& kwargs)
{
if(issubchild(type, BaseObject)){
...
}else if(issubchild(type, Node)){
....
}
}But this could be in a second PR.
| name = py::str(kwargs["name"]); | ||
| if (sofapython3::isProtectedKeyword(name)) | ||
| throw py::value_error("Cannot call addObject with name " + name + ": Protected keyword"); | ||
| } |
There was a problem hiding this comment.
Shouldn't we consider to add a name generation mechanism (with +1) to avoid having name duplicated.
Of course this have a non linear performance hit in case of gigantic scene... but I would be in favor of having a robust normal add() and a second one considered "fast mode" for expert users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method's goal is to reduce as much as possible thee data serialization